Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Reposition OcNotifications in web-runtime #7139

Merged
merged 1 commit into from
Jun 30, 2022
Merged

[full-ci] Reposition OcNotifications in web-runtime #7139

merged 1 commit into from
Jun 30, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Jun 17, 2022 •
edited
Loading

Description

Would like to put this approach up for discussion - instead of having UploadInfo and Notifications both absolutely positioned (and possibly overlapping), wrap them in an absolutely positioned container and don't position the two components individually

Related Issue

Checklist:

  • Needs Redesign notifications owncloud-design-system#2210 merged and (pre-)released, incl. an ODS-update in this PR
  • Check if the <oc-notifications> components in DrawIo and TextEditor can be removed - the Notifications live in the runtime&global store after all, and the two other usages look kinda broken also

Screenshot 2022-06-17 at 15-14-15 Personal - ownCloud

@ownclouders
Copy link
Contributor

ownclouders commented Jun 17, 2022 •
edited
Loading

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/26535/70/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L260.png

webUITrashbinRestore-trashbinRestore_feature-L260.png

@pascalwengerter pascalwengerter force-pushed the redesign-reposition-notifications branch from c3378ef to 39ce10a Compare June 22, 2022 11:44
@pascalwengerter pascalwengerter changed the title Draft: Reposition OcNotifications in web-runtime Reposition OcNotifications in web-runtime Jun 22, 2022
@pascalwengerter pascalwengerter marked this pull request as ready for review June 22, 2022 11:44
kulmann
kulmann approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. And pleases the eye. 🎨 🤩

@pascalwengerter
Copy link
Contributor Author

CI gets killed pretty early on each time without a hint towards why - investigating now, I bumped axios and webdav in this PR (owncloud-sdk requires newer versions as peerDependencies)

@pascalwengerter pascalwengerter changed the title Reposition OcNotifications in web-runtime [full-ci] Reposition OcNotifications in web-runtime Jun 22, 2022
@pascalwengerter pascalwengerter force-pushed the redesign-reposition-notifications branch 3 times, most recently from df49810 to 2f4bd4e Compare June 27, 2022 11:09
@pascalwengerter
Copy link
Contributor Author

At least

webUIDeleteFilesFolders/deleteFilesFolders.feature:126
webUIDeleteFilesFolders/deleteFilesFolders.feature:241

webUIFavorites/unfavoriteFile.feature:102
webUIFavorites/favoritesFile.feature:105

passed locally (with oC10) for me and fail in CI...

@pascalwengerter pascalwengerter force-pushed the redesign-reposition-notifications branch 5 times, most recently from 26ff18b to f5da6ee Compare June 30, 2022 09:39
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.8% 15.8% Coverage
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter merged commit 9591bfd into master Jun 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the redesign-reposition-notifications branch June 30, 2022 10:16
@pascalwengerter pascalwengerter mentioned this pull request Jun 30, 2022
Merged
@micbar micbar mentioned this pull request Jul 19, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications look different from the design + are blocking
3 participants
@pascalwengerter @ownclouders @kulmann